Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SDKLogger Override in Example App #32

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Adding SDKLogger Override in Example App #32

merged 4 commits into from
Oct 16, 2024

Conversation

mliao95
Copy link
Contributor

@mliao95 mliao95 commented Oct 15, 2024

Issue Number:

Description:

What are the changes? Why are we making them?

This PR enhances the SDK Logger example workflows in the example application. The SDK Logger example now includes overriding the SDKLogger with a custom logger that will output a log file when using the app.

There is also some import cleanup in the SDK's ChatSession.kt file.


Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO]

NO

Does this change introduce any new dependency? [YES/NO]

NO


Testing:

Is the code unit tested?

YES

Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?

YES

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mliao95 mliao95 requested a review from xiajon October 15, 2024 02:12
@mliao95 mliao95 requested a review from mrajatttt October 15, 2024 21:41
@mliao95 mliao95 merged commit d0f4c65 into main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants