change: nobraket branch #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
reviewed
Aug 9, 2024
rmshaffer
previously approved these changes
Aug 19, 2024
kshyatt-aws
force-pushed
the
ksh/nobraket
branch
from
7ad4185 to
615a471
Compare
rmshaffer
previously approved these changes
Aug 21, 2024
pyproject.toml
Outdated
Comment on lines
43
to
44
| "qiskit==1.1.2", | ||
| "qiskit-braket-provider==0.4.1", |
There was a problem hiding this comment.
Is it worth making these >= instead of ==, so that we might more quickly catch regressions in new versions? Otherwise we'll have to remember to come update this.
There was a problem hiding this comment.
Actually we should probably loosen them because this won't work with the NBIs (which are on older Qiskit) as is
|
Currently hunting down a performance issue related to the long time it takes to get a thread lock with |
* update tests * add a test optimization * refactor pyproject file to have test dependencies in their own file * Update requirements-test.txt * Update requirements-test.txt --------- Co-authored-by: Coull <[email protected]>
rmshaffer
previously approved these changes
Aug 26, 2024
* change: Use multiprocessing Pool rather than ProcessPoolExecutor * fix: No sigterm screaming * fix: Force close and join at exit * fix: Faster * fix: handle julia error in serializable way * change: Add benchmark workflow to CI * change: Point to latest unblocking branch * fix: linting * fix: Don't turn off juliapkg in tox * Update src/braket/simulator_v2/julia_workers.py Co-authored-by: Ryan Shaffer <[email protected]> * Update src/braket/simulator_v2/julia_workers.py Co-authored-by: Ryan Shaffer <[email protected]> * fix: one-line pip in benchmark * fix: typo * fix: Use benchmark-json option correctly * change: Add initial output.json * fix: Actually include benchmark script * fix: Don't deploy benchmark results to gh-pages * fix: restore GH token * fix: Remove benchmarks for now * change: Point to new BraketSimulator 0.0.4 --------- Co-authored-by: Ryan Shaffer <[email protected]>
rmshaffer
previously approved these changes
Aug 27, 2024
|
Verified latest commit works on an NBI with the Qiskit example notebook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Update for new removed
Braket.jlbranch. Stripped out JAQCD logic.Testing done:
toxpassed locally.Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.