fix: Force StateVector and DensityMatrix values to be ndarrays and test #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt-aws
force-pushed
the
ksh/array_type
branch
from
9c787ec to
3803744
Compare
krneta
reviewed
May 6, 2024
| @@ -473,6 +496,13 @@ def run_jaqcd( | |||
| ) | |||
| r = jl.simulate(self._device, [circuit_ir], qubit_count, shots) | |||
| r.additionalMetadata.action = circuit_ir | |||
| if not shots: | |||
There was a problem hiding this comment.
Might be a dumb question : should we be using _generate_results or _create_results_obj from the default sim?
There was a problem hiding this comment.
No, those are handled internally by the Julia sim already.
There was a problem hiding this comment.
In the shots=0 case, the expectation values/variances/whatever have already been calculated and populated into GateModelTaskResult.
krneta
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Convert the raw Python
listrepresentation of the state vector/density matrix result tonp.ndarraywhich is expected. Add a test for both IR types.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.