Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integ tests for result types for local and aws simulators and exa… #93

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Add integ tests for result types for local and aws simulators and exa… #93

merged 1 commit into from
Jun 5, 2020

Conversation

avawang1
Copy link
Contributor

@avawang1 avawang1 commented Jun 4, 2020

…mple script

*Issue #, if available: N/A

*Description of changes:

  • Add integ tests for result types for local and aws simulators
  • Add example script for result types
  • Fixed some whitespace for linters from previous commit
  • Fixed some pydantic validation errors from new pydantic release

build_files.tar.gz

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avawang1 avawang1 requested a review from speller26 June 4, 2020 03:47
speller26
speller26 reviewed Jun 4, 2020
View reviewed changes
examples/bell_result_types.py Outdated Show resolved Hide resolved
src/braket/circuits/circuit.py Outdated Show resolved Hide resolved
src/braket/circuits/circuit.py Outdated Show resolved Hide resolved
src/braket/circuits/circuit.py Outdated Show resolved Hide resolved
test/integ_tests/device_run_testing_utils.py Outdated Show resolved Hide resolved
test/unit_tests/braket/circuits/test_circuit.py Show resolved Hide resolved
test/integ_tests/device_run_testing_utils.py Outdated Show resolved Hide resolved
speller26
speller26 approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@speller26 speller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just add the z_hermitian case to the AWS simulator tests; it's already in the local simulator tests.

src/braket/circuits/circuit.py Show resolved Hide resolved
test/integ_tests/test_simulator_quantum_task.py Show resolved Hide resolved
@avawang1 avawang1 force-pushed the feature/integ-tests branch from 8d44012 to 2d44e27 Compare June 5, 2020 19:22
@amazon-braket amazon-braket deleted a comment from speller26 Jun 5, 2020
@avawang1 avawang1 merged commit c5a1435 into master Jun 5, 2020
@avawang1 avawang1 deleted the feature/integ-tests branch June 5, 2020 19:26
kshitijc pushed a commit that referenced this pull request Nov 29, 2021
@jheckey
Merge pull request #93 from aws/sync_branch_sdk
9c62a74 
sync: public sdk to staging sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speller26 speller26 speller26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avawang1 @speller26