infra: limit installs for dependent-tests.yml #792
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 129 129
Lines 8532 8532
Branches 1908 1908
=========================================
Hits 8532 8532 ☔ View full report in Codecov by Sentry. |
AbeCoull
changed the title
|
Associated PR:: amazon-braket/amazon-braket-pennylane-plugin-python#219 |
| pip install -e .[test] | ||
| pip install tox |
There was a problem hiding this comment.
Could you validate if this causes the tests to reference the SDK mainline instead of the current commit?
There was a problem hiding this comment.
I am unsure of the behavior when you left this comment so I added a deterministic change to the tox file to ensure the setup uses the working branch for the PR.
From the test logs:
unit-tests: install_deps> python -I -m pip install git+https://github.com/amazon-braket/amazon-braket-sdk-python.git@math411-patch-4
.github/scripts/update_dependency.py
Outdated
| replaced_line = ( | ||
| line | ||
| if package not in line | ||
| else f" git+https://github.com/amazon-braket/{package}-python.git@{args.branch}\n" |
There was a problem hiding this comment.
Would this work if someone is raising a PR from their personal fork. Is there a way we could handle that?
There was a problem hiding this comment.
I am testing this with a forked branch of the repo. The action runner syncs the repo so this should work across forks with the new commit
Issue #, if available:
Description of changes:
Testing done:
Tests go from an execution of 7-10 mins down to 4.5 minutes.
amazon-braket/amazon-braket-pennylane-plugin-python#219 - The Pennylane Plugin will now install the dependencies which allows the runner to not need to worry about installing them here. This also keeps the test envs consistent across runs.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.