-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support FreeParameter binding via make_bound_program
#779
feature: support FreeParameter binding via make_bound_program
#779
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/autoqasm #779 +/- ##
====================================================
- Coverage 100.00% 99.98% -0.02%
====================================================
Files 163 163
Lines 9761 9773 +12
Branches 2080 2085 +5
====================================================
+ Hits 9761 9772 +11
- Partials 0 1 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the API choice! Left a few minor comments, and also it would be good to get @jcjaskula-aws's opinion on the oqpy program manipulation here.
Adding some thoughts, if the IODeclaration does not need to be added in-place, we could investigate the use of |
63c146d
to
435ff75
Compare
Following up my comments, I'm proposing to explore something using |
Issue #, if available:
Closes #769
Description of changes:
Support
make_bound_program
The name and signature is patterned after
make_bound_circuit
. This name also helps inform the user that the method will make and return a new object, with the original left unchanged.Testing done:
New unit tests
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.