Add result types to ASCII diagram #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitijc
reviewed
May 15, 2020
Comment on lines
+331
to
+333
| "q0 : -C---H-Variance(Y)------------", | ||
| " | ", | ||
| "q1 : -|-C---Expectation(Hermitian)-", |
There was a problem hiding this comment.
Shorter symbol names might give a cleaner appearance for the diagrams: Variance -> Var, Expectation -> <>
There was a problem hiding this comment.
I'm erring on the side of having more explicit names to reduce user confusion, since there aren't really any standards for these result names.
kshitijc
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: N/A
*Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
build_files.tar.gz