-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dependency list for decorator hybrid jobs #764
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 129 129
Lines 8355 8360 +5
Branches 1860 1862 +2
=========================================
+ Hits 8355 8360 +5
☔ View full report in Codecov by Sentry. |
Getting formatting errors unrelated to changes made here. Will fix and see what's going on with the description workflow too |
src/braket/jobs/hybrid_job.py
Outdated
dependencies (str | Path | list[str]): Path (absolute or relative) to a requirements.txt | ||
file to be used for the hybrid job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependencies (str | Path | list[str]): Path (absolute or relative) to a requirements.txt | |
file to be used for the hybrid job. | |
dependencies (str | Path | list[str]): Path (absolute or relative) to a requirements.txt | |
file, or alternatively a list of strings, with each string being a `requirement specifier <https://pip.pypa.io/en/stable/reference/requirement-specifiers/#requirement-specifiers>`, to be used for the hybrid job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add some detail on what happens if there is already a requirements.txt
file that is being included through the include_modules
parameter and you additionally specify dependencies as a list of strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include_modules
only allows python modules (my_python_package.sub_module
etc) and does not directly access the file system, so there is no way for users to provide a requirements.txt
through include modules. include_modules
is a code-only construct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. I forgot about that. Happy to approve once the docstring is updated.
Issue #, if available:
Description of changes:
support listing dependencies by name instead of in a requirements file for decorator jobs
Testing done:
unit and manual testing
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.