Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc fixes #748

Merged
merged 2 commits into from
Oct 18, 2023
Merged

doc fixes #748

merged 2 commits into from
Oct 18, 2023

Conversation

krneta
Copy link
Contributor

@krneta krneta commented Oct 17, 2023

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krneta krneta requested a review from ajberdy October 17, 2023 22:46
@krneta krneta requested a review from a team as a code owner October 17, 2023 22:46
"""
_validate_python_version(image_uri, aws_session)

def _hybrid_job(entry_point):
def _hybrid_job(entry_point: Callable) -> Callable:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know more about what these changes are

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4cc0eba) 100.00% compared to head (c5683e8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #748   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8387      8387           
  Branches      1866      1866           
=========================================
  Hits          8387      8387           
Files Coverage Δ
src/braket/jobs/config.py 100.00% <ø> (ø)
src/braket/jobs/data_persistence.py 100.00% <100.00%> (ø)
src/braket/jobs/hybrid_job.py 100.00% <100.00%> (ø)
src/braket/jobs/image_uris.py 100.00% <100.00%> (ø)
src/braket/jobs/quantum_job_creation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krneta krneta merged commit f4957ec into main Oct 18, 2023
22 checks passed
@krneta krneta deleted the doc_fix branch October 18, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants