Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/0.3.4 #66

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Hotfix/0.3.4 #66

merged 3 commits into from
Apr 11, 2020

Conversation

avawang1
Copy link
Contributor

*Issue #, if available: N/A

Description of changes:

  • Reduce required arguments for AwsQuantumTask to just the ARN
  • Fix result caching bug in AwsQuantumTask where if task.result() times out, then task.state() is called and it's a terminal state, the task will not restart polling even if task.result() or task.async_result() is called

Note: v0.3.3 was already released but it wasn't changed in setup.py, hence going from 0.3.2 to 0.3.4

build_files.tar.gz

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avawang1 avawang1 requested a review from dbolt April 10, 2020 20:46
src/braket/aws/aws_quantum_task.py Outdated Show resolved Hide resolved
src/braket/aws/aws_quantum_task.py Show resolved Hide resolved
src/braket/aws/aws_quantum_task.py Outdated Show resolved Hide resolved
src/braket/aws/aws_quantum_task.py Outdated Show resolved Hide resolved
src/braket/aws/aws_quantum_task.py Show resolved Hide resolved
Copy link
Contributor

@dbolt dbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work on this one, def a tricky bug.

@avawang1 avawang1 merged commit 32bf930 into master Apr 11, 2020
@avawang1 avawang1 deleted the hotfix/0.3.4 branch April 11, 2020 00:15
kshitijc pushed a commit that referenced this pull request Nov 29, 2021
Correct comment on QAOA example notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants