Fix depth and ascii diagrams for circuits with overlapping multi-qubi… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanShields
approved these changes
Mar 6, 2020
floralph
approved these changes
Mar 6, 2020
| @@ -28,7 +28,7 @@ def build_diagram(circuit) -> str: | |||
| Build an ASCII string circuit diagram. | |||
|
|
|||
| Args: | |||
| circuit (Circuit): Circuit to build a diagram of. | |||
| circuit (Circuit): Circuit to build a diagram. | |||
There was a problem hiding this comment.
Shouldn't it be "Circuit for which to build a diagram"? :P
There was a problem hiding this comment.
That is more grammatically correct - will change then merge.
shiyunon
pushed a commit
to shiyunon/amazon-braket-sdk-python
that referenced
this pull request
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t gates
*Issue #, if available: N/A
*Description of changes: Fix depth and ASCII diagrams for circuits with overlapping multi-qubit gates. Previously overlapping multi-qubit gates e.g.
Circuit().cnot(0,2).cnot(1,3)had depth 2 when the circuit should have depth of 1. Also, ASCII diagram for this circuit showed each gate was in different times 0 and 1 when both gates should be time 0. Added unit tests for change.build_files.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.