Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples to instantiate gates instead of singletons AMAZON-QX-92 #37

Closed
wants to merge 2 commits into from

Conversation

floralph
Copy link
Contributor

Issue #, if available:
AMAZON-QX-92

Description of changes:
Updated examples to instantiate gates instead of singletons

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@floralph floralph requested a review from dbolt February 27, 2020 01:48
Copy link
Contributor

@dbolt dbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the recursion commit before you push, looks like its from the other PR you did.

@floralph
Copy link
Contributor Author

Resubmitting to remove extraneous commit from previous PR.

@floralph floralph closed this Feb 27, 2020
@floralph floralph deleted the floralph branch February 27, 2020 19:46
kshitijc pushed a commit that referenced this pull request Nov 29, 2021
… prov… (#37)

fix: only call aws_session.bucket() when s3_destination_folder is not provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants