Correctly cache status #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
licedric
reviewed
Nov 23, 2020
licedric
reviewed
Nov 23, 2020
| @@ -255,6 +256,10 @@ def _status(self, use_cached_value=False): | |||
| self._logger.warning(f"Task is in terminal state {status} and no result is available") | |||
| return status | |||
|
|
|||
| def _update_status_if_nonterminal(self): | |||
There was a problem hiding this comment.
This is still not ideal: consider the case where the metadata is empty and the status is "RUNNING".
Then first self._status(True) is called, filling the metadata and returning the "RUNNING" status.
Since it's not a terminal state, self._status(False) will be called again. This uses two GetQuantumTask calls.
There was a problem hiding this comment.
However, there will be at most one extra call to GetQuantumTask, and since the status isn't terminal, I don't think it hurts to make the extra call; it's going to have to poll again regardless. Easy enough to get rid of it though.
There was a problem hiding this comment.
In the scenario I described it's two successive calls to GetQuantumTask, so the second call will likely return the same result and be wasted. In any case, thanks for the fix.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
licedric
approved these changes
Nov 23, 2020
AbeCoull
pushed a commit
that referenced
this pull request
Feb 27, 2022
* fix: Add LHR to the list of device regions * test updates * fix: Add integration tests * formatting changes
AbeCoull
pushed a commit
that referenced
this pull request
Mar 7, 2022
* Added integration tests and LHR region to device configuration (#174) * fix: Add LHR to the list of device regions * test updates * fix: Add integration tests * formatting changes * fix: Return DiGraph for device.topology_graph (#175) * sync: Merge from public repository (#176) * infra: Pin docutils<0.18 in doc requirements (#283) docutils 0.18 was released on October 26, 2021, and with it came some [breaking changes](readthedocs/readthedocs.org#8616) for sphinx, and in turn [readthedocs builds](https://readthedocs.org/projects/amazon-braket-sdk-python/builds/15168485/). To keep doc builds working, docutils will be constrained to versions below 0.18. * prepare release v1.9.5.post0 * update development version to v1.9.6.dev0 * feature: Add support for jobs (#287) Co-authored-by: Viraj Chaudhari <[email protected]> Co-authored-by: Milan Krneta <[email protected]> Co-authored-by: Aaron Berdy <[email protected]> Co-authored-by: Lin <[email protected]> Co-authored-by: Roald Bradley Severtson <[email protected]> Co-authored-by: Christian Madsen <[email protected]> * fix: Skip jobs integration tests (#288) * prepare release v1.10.0 * update development version to v1.10.1.dev0 * feature: Adding integration tests for DM1 (#286) * feature: Adding integration tests for DM1 * Moved many_layers to test_quantum_task * formatting changes only Co-authored-by: Cody Wang <[email protected]> * prepare release v1.11.0 * update development version to v1.11.1.dev0 * fix: remove extraneous reference from local job container setup (#292) * prepare release v1.11.1 * update development version to v1.11.2.dev0 * feature: optimize IAM role retrieval (#299) * fix: Enable jobs integration tests (#289) * feature: Added is_available property to AwsDevice (#290) Added is_available property to AwsDevice that parses the availability window and current device status to return a boolean flag if the device is currently available. * prepare release v1.12.0 * update development version to v1.12.1.dev0 * feature: added controlled-sqrt-not gate (#297) * feature: added controlled-sqrt-not gate This makes certain circuits, like CHSH, more straightforward. This commit works in line with the following branches (also committed, separately): https://github.com/unprovable/amazon-braket-schemas-python.git@ctrl-v-gate https://github.com/unprovable/amazon-braket-default-simulator-python.git@ctrl-v-gate * fix: ran tox linters * fix: reverted tox.ini Co-authored-by: Mark C <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: Cody Wang <[email protected]> * prepare release v1.13.0 * update development version to v1.13.1.dev0 * feature: adding TwoQubitPauliChannel (#300) * prepare release v1.14.0 * update development version to v1.14.1.dev0 * documentation: fix documentation on environment variable to match the code. (#302) * prepare release v1.14.0.post0 * update development version to v1.14.1.dev0 * feat: Update region switching for regional device arns (#169) (#303) * prepare release v1.15.0 * update development version to v1.15.1.dev0 Co-authored-by: Cody Wang <[email protected]> Co-authored-by: ci <ci> Co-authored-by: Viraj Chaudhari <[email protected]> Co-authored-by: Milan Krneta <[email protected]> Co-authored-by: Aaron Berdy <[email protected]> Co-authored-by: Lin <[email protected]> Co-authored-by: Roald Bradley Severtson <[email protected]> Co-authored-by: Christian Madsen <[email protected]> Co-authored-by: Jacob Feldman <[email protected]> Co-authored-by: Mark Sweat <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: mbeach-aws <[email protected]> Co-authored-by: Yiheng Duan <[email protected]> Co-authored-by: Cody Wang <[email protected]> Co-authored-by: Viraj Chaudhari <[email protected]> Co-authored-by: Milan Krneta <[email protected]> Co-authored-by: Aaron Berdy <[email protected]> Co-authored-by: Lin <[email protected]> Co-authored-by: Roald Bradley Severtson <[email protected]> Co-authored-by: Christian Madsen <[email protected]> Co-authored-by: Jacob Feldman <[email protected]> Co-authored-by: Mark Sweat <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: Mark C <[email protected]> Co-authored-by: mbeach-aws <[email protected]> Co-authored-by: Yiheng Duan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.