feature: Add noise operations and methods to add noise to circuits #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noise classes are the building blocks of circuit for noise simulations. They can be used as operator in Instruction.
This function checks if the matrices of a Noise satisfy the condition of completely-positive trace-preserving (CPTP) maps.
This function allows user to add many Noise to a circuit at once at specified gates, qubits and times.
In circuit.moments, Instruction with Noise is keyed by NoiseMomentsKey() instead of MomentsKy. This prevents Noise from occupying additonal time stamp.
Previous check did not catch when probability = nan
When insert_strategy="inclusive", only add 1-qubit noise to a gate if gate.target is a subset of target_qubits.
yitinche
requested review from
avawang1,
floralph and
speller26
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
The CodeBuild CI fails because this repo has dependency on the "noise" branch of Schemas repo. I have checked that the CI will pass with the noise branch of Schemas. |
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
licedric
reviewed
Aug 20, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kshitijc
reviewed
Sep 1, 2020
|
|
||
| new_moments = Moments() | ||
| time_slices = circuit.moments.time_slices() | ||
| for time in range(circuit.depth): |
There was a problem hiding this comment.
I get the following (which seems off to me):
>>> from braket.circuits import Noise, Circuit
>>> noise = Noise.BitFlip(probability=0.2)
>>> circ = Circuit().x(0).cnot(0, 1).y(2)
>>> print(circ.add_noise(noise))
T : | 0 | 1 |
q0 : -X--------NBF(0.2)----------C-NBF(0.2)-
|
q1 : -NBF(0.2)-------------------X-NBF(0.2)-
q2 : -Y--------NBF(0.2)-NBF(0.2)------------
T : | 0 | 1 |
There was a problem hiding this comment.
Fixed now. The output is now:
T : | 0 | 1 |
q0 : -X--------NBF(0.2)-C--------NBF(0.2)-
|
q1 : -NBF(0.2)----------X--------NBF(0.2)-
q2 : -Y--------NBF(0.2)-NBF(0.2)----------
T : | 0 | 1 |
There was a problem hiding this comment.
The test for this case (not the exact same circuit, but a similar case) was added.
Link to the discussion: amazon-braket#149 (comment)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
speller26
reviewed
Sep 2, 2020
speller26
reviewed
Sep 2, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
… quantum annealing task (amazon-braket#235)
… quantum annealing task (amazon-braket#235)
|
Completed in #212 |
kshitijc
added a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add operations and a result type (density matrix) that are related to noise simulation.
Add add_noise method to Circuits class.
Build directory: build_files.tar.gz
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.