Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: Add details to setup.py #140

Merged
merged 1 commit into from
Aug 13, 2020
Merged

infra: Add details to setup.py #140

merged 1 commit into from
Aug 13, 2020

Conversation

speller26
Copy link
Member

So PyPi shows the relevant information

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26
infra: Add details to setup.py
5fdbac4 
So PyPi shows the relevant information
@amazon-braket-ci-bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: SDKPullRequestBuild
  • Commit ID: 5fdbac4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@speller26 speller26 merged commit 1dc67e0 into main Aug 13, 2020
@speller26 speller26 deleted the feature/description branch August 13, 2020 22:07
kshitijc added a commit that referenced this pull request Nov 29, 2021
@kshitijc
fix: Change default execution role to Amazon Braket Service-linked ro…
67f0a37 
…le (#140)
kshitijc added a commit that referenced this pull request Nov 29, 2021
@kshitijc
fix: Update to use default roles created using the console (#155)
08ebaa5 
* Revert "fix: Change default execution role to Amazon Braket Service-linked role (#140)"

This reverts commit 67f0a37.

* fix: Use default roles created using the console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avawang1 avawang1 avawang1 approved these changes

@floralph floralph Awaiting requested review from floralph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@speller26 @amazon-braket-ci-bot @avawang1