change: Set default for shots argument in AwsDevice.run to None instead of -1. #129
Conversation
licedric
requested review from
avawang1,
floralph and
speller26
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -80,7 +79,7 @@ def run( | |||
| self, | |||
| task_specification: Union[Circuit, Problem], | |||
| s3_destination_folder: AwsSession.S3DestinationFolder, | |||
| shots: int = _DUMMY_SHOTS, | |||
| shots: Optional[int] = None, | |||
There was a problem hiding this comment.
Does this make any difference?
There was a problem hiding this comment.
-1 as a dummy value seems arbitrary, and has tripped up us once in a bug bash. That being said, it's not a big deal if you want to leave it as is.
There was a problem hiding this comment.
Thanks, just wondering if this change is due to a customer-impacting bug, but it seems like the change is more for readability purposes. Please update the commit message to be prefixed with "change: ", as per https://github.com/aws/amazon-braket-sdk-python/blob/main/CONTRIBUTING.md#commit-your-change.
licedric
force-pushed
the
shots-default-fix
branch
from
51de821 to
4a3c139
Compare
licedric
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
Description of changes:
Set default for shots argument in AwsDevice.run to None instead of -1.
Testing done:
Unit tests.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.