feature: Updated AwsQuantumTask to use new device parameters #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
avawang1
reviewed
Aug 10, 2020
|
|
||
| # TODO: Update this to use `deviceCapabilities` from Amazon Braket's GetDevice operation | ||
| # in order to decide what parameters to build. | ||
| paradigm_paramters = GateModelParameters(qubitCount=circuit.qubit_count) |
avawang1
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updated the aws_quantum_task module to use the new device parameters and updated all documentation references to use the new structures.
Testing done:
Integration tests against prod are failing since the latest changes cannot be pushed yet. I ran the integration tests against Beta and all but IonQ tests were passing (this is due to me running the tests in beta pdx and cross region code was trying to call us-east-1 in beta which has no device).
build_files.tar.gz
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.