Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin cloudpickle==2.2.1 #1044

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: Pin cloudpickle==2.2.1 #1044

merged 2 commits into from
Nov 18, 2024

Conversation

jheckey
Copy link
Contributor

@jheckey jheckey commented Nov 18, 2024

SageMaker has currently pinned cloudpickle==2.2.1, but has a pending issue to resolve it. In the meantime, this is needed to maintain compatibility with the amazon-braket-containers.

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

SageMaker has currently pinned [cloudpickle==2.2.1](https://github.com/aws/sagemaker-python-sdk/blob/4b5659d191c089f5033c48147a3c2f1566e85fbc/pyproject.toml#L36), but has a pending issue to resolve it. In the meantime, this is needed to maintain compatibility with the amazon-braket-containers.
@jheckey jheckey requested a review from a team as a code owner November 18, 2024 20:30
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90ca196) to head (737a62b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1044   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         9033      9033           
  Branches      1037      1037           
=========================================
  Hits          9033      9033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shpface shpface changed the title Pin cloudpickle==2.2.1 fix: Pin cloudpickle==2.2.1 Nov 18, 2024
Line too long
@jheckey jheckey merged commit a7348c6 into main Nov 18, 2024
26 checks passed
@jheckey jheckey deleted the pin-cloudpickle-2 branch November 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants