Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer copy profile name when copying session #10

Merged
merged 1 commit into from
Dec 18, 2019
Merged

No longer copy profile name when copying session #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/braket/aws/aws_qpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def _aws_session_for_qpu(self, qpu_arn: str, aws_session: AwsSession) -> AwsSess
aws_access_key_id=creds.access_key,
aws_secret_access_key=creds.secret_key,
aws_session_token=creds.token,
profile_name=aws_session.boto_session.profile_name,
region_name=qpu_regions[0],
)
return AwsSession(boto_session=boto_session)
Expand Down
3 changes: 1 addition & 2 deletions test/unit_tests/braket/aws/test_aws_qpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,11 @@ def test_aws_session_in_another_qpu_region(

AwsQpu(arn, different_region_aws_session)

# assert creds, profile, and region were correctly supplied
# assert creds, and region were correctly supplied
boto_session_init.assert_called_with(
aws_access_key_id=creds.access_key,
aws_secret_access_key=creds.secret_key,
aws_session_token=creds.token,
profile_name=different_region_aws_session.boto_session.profile_name,
region_name=region,
)

Expand Down