Skip to content

Commit

Permalink
fix: remove extraneous reference from local job container setup (#292)
Browse files Browse the repository at this point in the history
  • Loading branch information
ajberdy authored and krneta committed Jan 3, 2022
1 parent 1064627 commit 8a8da5b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
15 changes: 0 additions & 15 deletions src/braket/jobs/local/local_job_container_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def setup_container(
run_environment_variables.update(
_get_env_script_mode_config(creation_kwargs["algorithmSpecification"]["scriptModeConfig"])
)
run_environment_variables.update(_get_env_additional_lib())
run_environment_variables.update(_get_env_default_vars(aws_session, **creation_kwargs))
if _copy_hyperparameters(container, **creation_kwargs):
run_environment_variables.update(_get_env_hyperparameters())
Expand Down Expand Up @@ -113,20 +112,6 @@ def _get_env_script_mode_config(script_mode_config: Dict[str, str]) -> Dict[str,
return result


def _get_env_additional_lib() -> Dict[str, str]:
"""For preview, we have some libraries that are not available publicly (yet). The container
will install these libraries if we set this env variable.
Returns:
(Dict[str, str]): The set of key/value pairs that should be added as environment variables
to the running container.
"""
return {
"AMZN_BRAKET_IMAGE_SETUP_SCRIPT": "s3://amazon-braket-external-assets-preview-us-west-2/"
"HybridJobsAccess/scripts/setup-container.sh",
}


def _get_env_default_vars(aws_session: AwsSession, **creation_kwargs) -> Dict[str, str]:
"""This function gets the remaining 'simple' env variables, that don't require any
additional logic to determine what they are or when they should be added as env variables.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ def expected_envs():
return {
"AMZN_BRAKET_CHECKPOINT_DIR": "/opt/omega/checkpoints",
"AMZN_BRAKET_DEVICE_ARN": "test device ARN",
"AMZN_BRAKET_IMAGE_SETUP_SCRIPT": "s3://amazon-braket-external-assets-preview-us-west-2/"
"HybridJobsAccess/scripts/setup-container.sh",
"AMZN_BRAKET_JOB_NAME": "Test-Job-Name",
"AMZN_BRAKET_JOB_RESULTS_DIR": "/opt/braket/model",
"AMZN_BRAKET_JOB_RESULTS_S3_PATH": "test_location/Test-Job-Name/output",
Expand Down

0 comments on commit 8a8da5b

Please sign in to comment.