Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of execution counter in AWS qubit device fixed #114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

drelu
Copy link

@drelu drelu commented Oct 15, 2022

*Issue #, if available: None

*Description of changes: Increment counter for num_executions for single and batch executions so that BraketQubitDevice behaves consistent with Pennylane specification in base class: https://docs.pennylane.ai/en/stable/code/api/pennylane.Device.html#pennylane.Device.num_executions

*Testing done: Unit test provided

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Andre Luckow added 2 commits October 15, 2022 12:06
Increment counter for num_executions for single and batch executions so that BraketQubitDevice behaves consistent with Pennylane specification in base class: <https://docs.pennylane.ai/en/stable/code/api/pennylane.Device.html#pennylane.Device.num_executions>
@drelu drelu requested a review from a team as a code owner October 15, 2022 10:35
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #114 (61dd745) into main (a3635d6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          654       656    +2     
  Branches        92        92           
=========================================
+ Hits           654       656    +2     
Impacted Files Coverage Δ
src/braket/pennylane_plugin/braket_device.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants