Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hadamard test #157

Closed
wants to merge 1 commit into from
Closed

Add Hadamard test #157

wants to merge 1 commit into from

Conversation

blolt
Copy link

@blolt blolt commented Jan 11, 2025

This PR addresses issue #72.

Description of changes: This PR adds the Hadamard test to the library's implemented algorithms, with an optional flag that can be toggled for estimating either the real or imaginary part of the controlled unitary. An extension could be implementing the modified hadamard test, which could possibly make use of Amplitude amplification (Issue #100).

Testing done: Unit tests and notebook created.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@blolt blolt requested a review from a team as a code owner January 11, 2025 19:01
@blolt blolt closed this Jan 11, 2025
@blolt
Copy link
Author

blolt commented Jan 11, 2025

Closed this as it was the wrong commit. See the correct commit in this PR here: #158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant