Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Update to new BraketSimulator interface #90

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Update the LocalSimulator interface to handle the updates to BraketSimulator.jl

Testing done: BraketSimulator.jl tests passed

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (f357046) to head (a206e49).

Files Patch % Lines
src/local_simulator.jl 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   88.74%   89.03%   +0.29%     
==========================================
  Files          36       36              
  Lines        3927     3914      -13     
==========================================
  Hits         3485     3485              
+ Misses        442      429      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws
Copy link
Member Author

Example notebook is broken because BraketSimulator.jl's interface branch needs merging

@kshyatt-aws kshyatt-aws merged commit 10c6548 into main Jun 20, 2024
19 of 21 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/parsing branch June 20, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant