Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serde pickle V4 #88

Merged

Conversation

WingCode
Copy link

Issue #, if available: #18

Description of changes: Using Pickle.jl library to serialise and deserialise pickle objects.
Pickle.jl was chosen because:

  • It is in native Julia and doesn't require Python call.
  • Does only pickling compared to Pandas.jl
  • More recent and up to date package compared to alternative PythonIO.jl

Testing done: Locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer linked an issue Jun 11, 2024 that may be closed by this pull request
@kshyatt-aws
Copy link
Member

Rerunning CI as the failures don't look to be the fault of this PR. I'll mark it approved so UH picks it up.

@kshyatt-aws kshyatt-aws self-requested a review June 19, 2024 18:49
Copy link
Member

@kshyatt-aws kshyatt-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait to merge until CI passes, or merge into a feature branch

@kshyatt-aws kshyatt-aws changed the base branch from main to ksh/feature_bump August 28, 2024 17:01
@kshyatt-aws kshyatt-aws merged commit f5ec984 into amazon-braket:ksh/feature_bump Aug 28, 2024
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support for loading pickled results from Hybrid Jobs
2 participants