Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump package versions, test on 1.9, and fix warnings #34

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available:

N/A

Description of changes:

  • Bump versions of dependencies
  • Fix several warnings arising from AWS.jl
  • Fix bad method piracy of apply
  • Fix re-use of mock functions
  • Use 1.9 beta version in CI (allow fail)

Testing done:

Ran unit and integ tests locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 93.02% // Head: 92.99% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (5cedd3d) compared to base (b3f6b85).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   93.02%   92.99%   -0.03%     
==========================================
  Files          33       33              
  Lines        3684     3684              
==========================================
- Hits         3427     3426       -1     
- Misses        257      258       +1     
Impacted Files Coverage Δ
src/Braket.jl 100.00% <ø> (ø)
src/device.jl 85.21% <100.00%> (ø)
src/jobs.jl 97.56% <100.00%> (ø)
src/noise_model.jl 100.00% <100.00%> (ø)
src/task.jl 91.36% <100.00%> (ø)
src/qubit_set.jl 76.47% <0.00%> (-1.97%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kshyatt-aws kshyatt-aws merged commit cfb67a9 into main Feb 3, 2023
@kshyatt-aws kshyatt-aws deleted the ksh/condapkg_bump branch February 3, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants