Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint support in Braket.jl #19

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Adjoint support in Braket.jl #19

merged 1 commit into from
Dec 8, 2022

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available:

Description of changes:

Add Julia support for adjoint gradient computation on Amazon Braket.

Switches default IR format to OpenQASM.

Testing done:

Unit and integ tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws added the enhancement New feature or request label Dec 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 94.43% // Head: 93.02% // Decreases project coverage by -1.40% ⚠️

Coverage data is based on head (e69037c) compared to base (3d68d4f).
Patch coverage: 76.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   94.43%   93.02%   -1.41%     
==========================================
  Files          33       33              
  Lines        3504     3671     +167     
==========================================
+ Hits         3309     3415     +106     
- Misses        195      256      +61     
Impacted Files Coverage Δ
src/schemas.jl 100.00% <ø> (ø)
src/task_batch.jl 84.28% <50.00%> (-7.65%) ⬇️
src/raw_schema.jl 95.76% <58.33%> (-0.94%) ⬇️
src/task.jl 91.31% <65.30%> (-6.96%) ⬇️
src/circuit.jl 95.71% <70.58%> (-1.26%) ⬇️
src/results.jl 92.15% <77.77%> (-1.88%) ⬇️
src/observables.jl 86.30% <80.64%> (-11.48%) ⬇️
PyBraket/src/pycircuit.jl 76.47% <90.90%> (-1.66%) ⬇️
PyBraket/src/pyschema.jl 98.38% <100.00%> (+0.69%) ⬆️
src/Braket.jl 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kshyatt-aws kshyatt-aws merged commit 335e08b into main Dec 8, 2022
@kshyatt-aws kshyatt-aws deleted the ksh/adjoint branch December 8, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants