Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Dockerhub image fix - (fix_yahoo_finance) #9

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

ruecarlo
Copy link
Contributor

@ruecarlo ruecarlo commented Feb 1, 2019

Issue #6 , Docker image points now to ruecarlo/montecarlo-workshop-worker:latest :

  1. The docker image was missing the fix_yahoo_finance dependency due to issues with the latest versions of the yahoo_finance library
  2. User data / spotlabworker.sh has also been amended to apply exactly the same fix. Additionally an issue related with incompatible image botocore used by awscli and boto3 was found and required upgrading linux packages
  3. Links that reference the local repo have been changed to refer to relative paths (fork-friendly)
  4. A few cosmetic changes in the README.md markdown related mainly with: Markdown cosmetic issues.
  5. Readme.bak removed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Changed Dockerfile to avoid creating unnecessary layers for python installation

* Removed github references; Using relative references within the same repo

* fixed issue with template link and bold items in template table

* workers were failing due to missing pip as a dependency. Added pip and flatten the dependencies into a single execution

* Applied same changes to the spotlabworker.sh

* added awscli to dependencies (running into this issue with botocore update aws/aws-cli#3542)

* Adding fix_yahoo_finance to the list of dependencies

* docker image pointing to the fixed repo in dockerhub
@ruecarlo ruecarlo changed the title Development (#1) Dockerhub image fix - (fix_yahoo_finance) Feb 1, 2019
@oak2278 oak2278 merged commit d9df6f6 into amazon-archives:master Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants