This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Fix duplicate events and comments #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
erezrokah
commented
Apr 13, 2018
| @@ -36,7 +36,8 @@ const client = new AWSAppSyncClient({ | |||
| auth: { | |||
| type: appSyncConfig.authenticationType, | |||
| apiKey: appSyncConfig.apiKey, | |||
| } | |||
| }, | |||
| disableOffline: true | |||
There was a problem hiding this comment.
erezrokah
commented
Apr 13, 2018
| @@ -86,7 +86,10 @@ export default compose( | |||
| const query = QueryAllEvents; | |||
| const data = proxy.readQuery({ query }); | |||
|
|
|||
| data.listEvents.items = data.listEvents.items.filter(event => event.id !== deleteEvent.id); | |||
| const index = data.listEvents.items.findIndex(event => event.id === deleteEvent.id) | |||
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #14
Detailed explanation here:
https://stackoverflow.com/questions/49118378/apollo-mutate-calling-update-four-times-for-a-single-mutation
Mutation update event is triggered 4 times instead of 2 for each mutation causing duplication.
This can be handled by setting
disableOffline: true(see here https://docs.aws.amazon.com/appsync/latest/devguide/building-a-client-app-react.html#offline-settings)I've also updated the code that handled duplication since it is only required in
NewComment.jsandEventComments.js.I'm not sure if there is a better way of fixing this issue using some kind of
AppSyncconfiguration while avoidingdisableOffline: true.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
See here as well: awslabs/aws-mobile-appsync-sdk-js#65