Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Rails 6.1.0 #75

Closed
crigor opened this issue Dec 17, 2020 · 2 comments · Fixed by #77
Closed

Support for Rails 6.1.0 #75

crigor opened this issue Dec 17, 2020 · 2 comments · Fixed by #77

Comments

@crigor
Copy link

crigor commented Dec 17, 2020

Hi Akira. Thank you for creating this gem.

database_rewinder currently doesn't work on rails 6.1.0 because ActiveRecord::Base.configurations returns a hash with symbols as keys. There are 2 PRs that solve this problem and #70 also removes the rails 6.2 deprecation warnings.

@JuanitoFatas Does your PR need more changes?
@JuanitoFatas
Copy link
Contributor

JuanitoFatas commented Dec 17, 2020 •
edited
Loading

Hey Christopher ☺️!!

#70 has been working fine with my personal Rails app since 6.1 (now 6.2 alpha)!

I am happy to follow up with any compatible change if I miss anything.

@harunorimurata
Copy link

@JuanitoFatas
Hi, Juanito-san!
Can you please fix #70 ?
It failed to build on Rails 6.0.

@r7kamura r7kamura mentioned this issue Apr 16, 2021
Merged
@hgwr hgwr mentioned this issue Apr 22, 2021
Closed
amatsuda added a commit that referenced this issue Apr 26, 2021
@amatsuda
Merge pull request #77 from r7kamura/feature/rails-6-1
30133d8 
Add support for Rails 6.1

fixes #75
closes #70 #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@crigor @JuanitoFatas @harunorimurata