-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Turbo to v2.2 #1449
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
39b1b74
chore: Update Turbo
amannn 350e9cb
simplify turbo outputs
amannn c82f192
prod deployment
amannn a14cec5
more parallelization?
amannn 9ed0e95
lint depends on build
amannn a06ab0e
only affected
amannn 37795af
increase fetch depth
amannn 8ba95e4
decrease fetch depth?
amannn 187dfe8
remove unused params
amannn 87be605
try to re-enable playwright caching
amannn c2a6391
try to fix pw version
amannn 0558283
use modern output
amannn 18e1757
attempt to fix output
amannn 8e12970
Merge branch 'main' into chore/turbo-2-2
amannn de9aff2
restore nextjs cache for docs too
amannn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ node_modules/ | |
dist/ | ||
.next/ | ||
tsconfig.tsbuildinfo | ||
.turbo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,11 +2,7 @@ | |
"name": "root", | ||
"private": true, | ||
"scripts": { | ||
"build": "turbo run build --env-mode=loose", | ||
"test": "turbo run test --concurrency 1 --env-mode=loose", | ||
"lint": "turbo run lint --env-mode=loose", | ||
"postinstall": "turbo run build --filter './packages/**' --env-mode=loose", | ||
"size": "turbo run size --env-mode=loose", | ||
"postinstall": "turbo run build --filter './packages/**'", | ||
"publish": "lerna publish" | ||
}, | ||
"devDependencies": { | ||
|
@@ -24,7 +20,7 @@ | |
"conventional-changelog-conventionalcommits": "^7.0.0", | ||
"execa": "^9.2.0", | ||
"rollup": "^4.18.0", | ||
"turbo": "^2.0.4" | ||
"turbo": "^2.2.3" | ||
}, | ||
"packageManager": "[email protected]" | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been following the guide at https://vercel.com/docs/monorepos/remote-caching#enable-and-disable-remote-caching-for-your-team.
Step 1
"Remote Caching" is enabled for the "next-intl" team on Vercel.
Step 2
Running
npx turbo login
locally yields this error:Step 3
Running
npx turbo link
did work though.Step 4
(skipped)
Step 5
Locally Turbo caching works as expected (was already the case before).
CI Config
TURBO_TEAM
is set tonext-intl
in a GH Actions variableTURBO_TOKEN
is set in a GH Actions secretnext-intl/.github/workflows/main.yml
Lines 11 to 13 in fd681ad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the most recent CI run: https://github.com/amannn/next-intl/actions/runs/11474295438/job/31929959155?pr=1449.
At the beginning of "Run pnpm run build" there are these entries: