-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for using next-intl
in the app
folder with Next.js 13
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
amannn
changed the title
docs: Next.js 13
feat: Next.js 13 Nov 30, 2022
app
folder exampleapp
folder support & example
# Conflicts: # packages/next-intl/package.json
amannn
changed the title
feat: Next.js 13
feat: Add support for using Dec 8, 2022
app
folder support & examplenext-intl
in the app
folder with Next.js 13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the minimal change that we have to do to be able for
next-intl
to be used in the app folder.Features:
NextIntlProvider
can now be used in theapp
folder. Note that all components that make use ofuseTranslations
oruseIntl
still need to be marked with'use client';
. A way to remove this restriction is explored in feat!: Next.js 13 RSC integration #149.import {createIntlMiddleware} from 'next-intl/server';
Pre-release:
CodeSandbox
Fixes #147
What's missing
pathname
in the root layout to set the<html lang={…} />
prop correctly (reference).What's nice to have
locale
directly in the request storage (likecookies()
) to be able to use this conveniently everywhereheaders()
andcookies()
in middleware for a unified interfacecookies()
APIPotential TODOs
[email protected]
Generate locales staticallyThis is not called for me during the build, no idea why. Bug?next-intl
in headhtml[lang]