feat: including media permission #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for the contribution! Will create a new release with this soon. |
amanharwara
reviewed
Oct 20, 2024
| @@ -26,6 +27,7 @@ export const getDefaultTab = (): Tab => ({ | |||
| config: { | |||
| theme: "dark", | |||
| notifications: true, | |||
| media: false, | |||
There was a problem hiding this comment.
actually I think it makes sense to have this be on by default since most users will want it to work without having to turn on a setting.
i've already merged the PR, so I'll just make that change on main before I create the release
There was a problem hiding this comment.
I agree, it makes sense the default to be enabled!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At linux was not possible to send audio via microphone or using the webcam, not sure but this was probably happening in others operating system.
This PR allow to set the permission for media (camera and microphone) per tab and now allowing to use camera or microphone.