Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unused addChatID and fix preload startup detection #204

Merged
merged 7 commits into from
Aug 5, 2022
Merged

Conversation

fznhq
Copy link
Contributor

@fznhq fznhq commented Aug 3, 2022

webview needs contextIsolation=false to make sure preload can access reactFiber object

fznhq added 6 commits August 3, 2022 13:09
webview needs contextIsolation=false to make sure preload can access reactFiber object
Copy link
Owner

@amanharwara amanharwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! I'm not sure what the chat IDs are actually being used for now. I believe I had implemented that for the chat online/offline indicator, but I've since stopped supporting that because it's difficult to keep up with changes in how WhatsApp handles that. I'm inclined to remove that file as well.

Please remove changes reload to that and delete that file as well. We can keep the changes to the preload that are not related to this.

Thanks again for your contribution.

@fznhq
Copy link
Contributor Author

fznhq commented Aug 5, 2022

Hi, thanks for the contribution! I'm not sure what the chat IDs are actually being used for now. I believe I had implemented that for the chat online/offline indicator, but I've since stopped supporting that because it's difficult to keep up with changes in how WhatsApp handles that. I'm inclined to remove that file as well.

Please remove changes reload to that and delete that file as well. We can keep the changes to the preload that are not related to this.

Thanks again for your contribution.

Sure

@fznhq fznhq changed the title feat: fix webview and preload feat: remove unused addChatID and fix preload startup detection Aug 5, 2022
@fznhq fznhq requested a review from amanharwara August 5, 2022 08:29
@amanharwara amanharwara merged commit ad54876 into amanharwara:master Aug 5, 2022
@fznhq
Copy link
Contributor Author

fznhq commented Aug 5, 2022

@amanharwara thanks, but I forgot to remove the unused import addChatID on preload, can you do that?

@amanharwara
Copy link
Owner

@amanharwara thanks, but I forgot to remove the unused import addChatID on preload, can you do that?

Yes, done.

@fznhq
Copy link
Contributor Author

fznhq commented Aug 5, 2022

@amanharwara Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants