-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove unused addChatID and fix preload startup detection #204
Conversation
webview needs contextIsolation=false to make sure preload can access reactFiber object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution! I'm not sure what the chat IDs are actually being used for now. I believe I had implemented that for the chat online/offline indicator, but I've since stopped supporting that because it's difficult to keep up with changes in how WhatsApp handles that. I'm inclined to remove that file as well.
Please remove changes reload to that and delete that file as well. We can keep the changes to the preload that are not related to this.
Thanks again for your contribution.
Sure |
@amanharwara thanks, but I forgot to remove the unused import addChatID on preload, can you do that? |
Yes, done. |
@amanharwara Thanks |
webview needs contextIsolation=false to make sure preload can access reactFiber object