Skip to content

Commit

Permalink
Merge pull request #184 from alyf-de/bump-fintech
Browse files Browse the repository at this point in the history
fix: bump fintech to 7.6.4
  • Loading branch information
barredterra authored Feb 16, 2025
2 parents 4e47f6b + d6f2269 commit ce12a9d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
11 changes: 0 additions & 11 deletions banking/ebics/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ def sync_ebics_transactions(
user.company,
sub_transaction,
user.start_date,
is_sub_transaction=True,
)
else:
_create_bank_transaction(bank_account, user.company, transaction, user.start_date)
Expand All @@ -168,7 +167,6 @@ def _create_bank_transaction(
company: str,
sepa_transaction: "SEPATransaction",
start_date: "date" = None,
is_sub_transaction: bool = False,
):
"""Create an ERPNext Bank Transaction from a given fintech.sepa.SEPATransaction.
Expand Down Expand Up @@ -206,15 +204,6 @@ def _create_bank_transaction(
bt.bank_party_iban = sepa_transaction.iban
bt.bank_party_name = sepa_transaction.name

if is_sub_transaction and not bt.bank_party_name:
# Temporary workaround to parse the party name from camt.052.001.08
# Can be removed once it's supported by the fintech library
bt.bank_party_name = (
sepa_transaction._xmlobj.RltdPties.Dbtr.Pty.Nm._text
if sepa_transaction._xmlobj.CdtDbtInd._text == "CRDT"
else sepa_transaction._xmlobj.RltdPties.Cdtr.Pty.Nm._text
)

with contextlib.suppress(frappe.exceptions.UniqueValidationError):
bt.insert()
bt.submit()
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# frappe -- https://github.com/frappe/frappe is installed via 'bench init'
fintech~=7.6.3
fintech==7.6.4

0 comments on commit ce12a9d

Please sign in to comment.