Modified MQTT string functions #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the "not so secure" print and copy function with the securer "n" variants of them.
Removed a for loop for coping byte-by-byte to a string buffer with strncpy and a cast to a char pointer.
Both variants (pure MQTT and MQTT with Home Assistant) need to do the same plausibility check for the incoming message (topic split to more then 2 commands), so not needed to have doubled code.
Fixed a typo in a variable name (subscibeTopic -> subscribeTopic).
Renamed variables from message2 to message.