Fixed timezone UI problems - Changed timezone set behavoir - changed dimming applying #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir of the manual timezone setting menu - changed shown values of the timezone
Martinius79
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do a squash merge!
Fixed timezone UI problems ->
Dimming was not applied correctly if timezone changed from the menu and reached night time/day time.
menu was not redrawn (so not visible anymore), if the tens hours digit changed while timezone set.
Changed timezone set behavoir ->
The timezone offset value is now "wrapped around" if -12 or +12 h is reached.
Changed timezone menu drawing ->
For negative values a minus (-) is drawn in front of the actual offset.
For positive values a plus (+) is drawn in front of the actual offset.
For 0:00 no sign at all.
minor changes in the serial/debug outputs and the code formatting
renamed and changed the variables and functions for dimming in main.cpp
added a public setDimming() method to Backlights class and put member variable "dimming" to private
placed all "auto night time dimming" stuff behind IFDEFs