Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pictures in data - modfied partition table CSV #89

Closed
wants to merge 2 commits into from

Conversation

Martinius79
Copy link
Collaborator

  • Fixed some clock faces in the data subfolder
    bit depth was mixed for some clock faces (CFs), now all 8bit palettized
    one CF was cropped to much
  • Changed names of the CFs in the txt for home assistant (HA)
  • Changed partition table file into slightly better readable version

@aly-fly
Copy link
Owner

aly-fly commented Nov 6, 2024

I don't remember exactly the reason, but most probably the mixed file types was intentional, to reduce file sizes as much as possible. For us with 4 MB Flash the space is totally full and I remember doing all sorts of testing to squeeze them as much as possible, to be able to upload as many different faces as possible. Viewing the commit file sizes, they range from 36 % to 210%. I recommend skipping the edits that increase the file size.

@Martinius79
Copy link
Collaborator Author

I get your point... You want to reduce the size to the max.

In the 50ths clock face set, images are sometimes 4-bit and sometimes 24-bit, so I brought all to 8-bit, but they could also be just 4-bit for all, which would reduce the size.

image
image

35.bmp is just 24-bit, instead of 8-bit, so I changed it.

image

The other two sets are cropped or changed, but I guess this is intended. My intention was to use the "original" versions, but no need to do that...

This set is cropped and the colours are brighter.
image
image

In the last set, is a "grid" in the background, which is hard to see that it is cropped.
image
image

I will close the PR and create a new one, with just the first mentioned files.

@Martinius79
Copy link
Collaborator Author

Will do it again later...

@Martinius79 Martinius79 closed this Nov 8, 2024
@Martinius79 Martinius79 deleted the FixPicturesInData branch November 8, 2024 01:13
@aly-fly
Copy link
Owner

aly-fly commented Nov 8, 2024

50 and 51 .bmp - this is a mistake.
35.bmp - this one looses a lot of detail if color depth is reduced and doesn't look nice. Tested.
48.bmp - I remember editing that set heavily, to achieve nice vibrant colors on the LCD displays. Originals are very dull.
71.bmp - LCDs on the clock have noticeably worse color and detail representation than computer monitors, this was cropped on the visual edge on LCDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants