This repository has been archived by the owner on Oct 27, 2018. It is now read-only.
Added support for input state and feedback. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support input status with success, error and warning and feedback. Added a mixin file for bootstrap-chosen (bootstrap-chosen-mixinx) and a new variable for padding the feedback chosen.
rafaeldias
changed the title
rafaeldias
changed the title
|
Looks good to me. I'm uncertain about the feedback icon in the deselect case, maybe it's time to modify the sprite sheet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been through a situation where I needed the input state and feedback icon integrated with chosen.
There is now support for control validation:
Also, it's now possible to use
has-feedbackwith chosen :There is only one problem with a chosen with single select and deselect enabled :
As you can see, the icon of the feedback overlaps the icon of the deselect.
I thought of positioning the feedback icon out of the chosen select box in this case :
But I don't know if it's a good idea. What do you think?
File for mixins has been added for better maintenance. Also a new variable has been added for padding the feedback chosen.
Less and Sass tested.