Skip to content

docs: 📝 Add 20.7.0 changelog #699

docs: 📝 Add 20.7.0 changelog

docs: 📝 Add 20.7.0 changelog #699

GitHub Actions / clippy succeeded Apr 6, 2024 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.77.1 (7cf61ebde 2024-03-27)
  • cargo 1.77.1 (e52e36006 2024-03-26)
  • clippy 0.1.77 (7cf61ebd 2024-03-27)

Annotations

Check warning on line 187 in alvr\client_openxr\src\stream.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

inequality checks against true can be replaced by a negation

warning: inequality checks against true can be replaced by a negation
   --> alvr\client_openxr\src\stream.rs:187:13
    |
187 |             config.encoder_config.enable_hdr != true,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!config.encoder_config.enable_hdr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
    = note: `#[warn(clippy::bool_comparison)]` on by default

Check warning on line 181 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr\client_openxr\src\lib.rs:181:9
    |
181 |     let mut stream_config = None::<StreamConfig>;
    |         ----^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`

Check warning on line 180 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr\client_openxr\src\lib.rs:180:9
    |
180 |     let mut last_lobby_message = String::new();
    |         ----^^^^^^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 325 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `last_lobby_message` is never read

warning: value assigned to `last_lobby_message` is never read
   --> alvr\client_openxr\src\lib.rs:325:25
    |
325 |                         last_lobby_message = message.clone();
    |                         ^^^^^^^^^^^^^^^^^^
    |
    = help: maybe it is overwritten before being read?
    = note: `#[warn(unused_assignments)]` on by default

Check warning on line 193 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_stream`

warning: unused variable: `xr_frame_stream`
   --> alvr\client_openxr\src\lib.rs:193:51
    |
193 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                                                   ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`

Check warning on line 193 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_waiter`

warning: unused variable: `xr_frame_waiter`
   --> alvr\client_openxr\src\lib.rs:193:30
    |
193 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                              ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`

Check warning on line 193 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_session`

warning: unused variable: `xr_session`
   --> alvr\client_openxr\src\lib.rs:193:14
    |
193 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |              ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`

Check warning on line 181 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `stream_config`

warning: unused variable: `stream_config`
   --> alvr\client_openxr\src\lib.rs:181:13
    |
181 |     let mut stream_config = None::<StreamConfig>;
    |             ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`

Check warning on line 180 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `last_lobby_message`

warning: unused variable: `last_lobby_message`
   --> alvr\client_openxr\src\lib.rs:180:13
    |
180 |     let mut last_lobby_message = String::new();
    |             ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 199 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable definition

warning: unreachable definition
   --> alvr\client_openxr\src\lib.rs:199:13
    |
195 |                 .create_session(xr_system, &egl_context.session_create_info())
    |                                             --------------------------------- any code following this expression is unreachable
...
199 |         let xr_context = XrContext {
    |             ^^^^^^^^^^ unreachable definition
    |
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
   --> alvr\client_openxr\src\lib.rs:195:45
    |
195 |                 .create_session(xr_system, &egl_context.session_create_info())
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[warn(unreachable_code)]` on by default

Check warning on line 12 in alvr\xtask\src\packaging.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `build_windows_installer` is never used

warning: function `build_windows_installer` is never used
  --> alvr\xtask\src\packaging.rs:12:4
   |
12 | fn build_windows_installer() {
   |    ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default