feat: Change Pico platform detection #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curoviyxru
changed the title
zmerp
reviewed
Jan 31, 2025
zmerp
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Sorry, forgot to say, it's missing a bunch of refactoring in alvr_client_openxr. Each instance of Pico4 needs to be updated to include Pico4Pro and Pico4Enterprise. furthermore, pico eye/face tracking and relative permission requests should be restricted only to Pico4Pro now that we have a more granular device detection
Rebased on master. Pico G3 controller profile should be added in a separate PR. Models other than Pico 4 Pro and Pico 4 Enterprise do support audio-based face tracking.
curoviyxru
force-pushed
the
pico-product-detection
branch
from
aa148eb to
4c2a5cd
Compare
zmerp
requested changes
Jan 31, 2025
zmerp
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
Platform::Pico4EnterpriseandPlatform::Pico4Pro, changes device model detection criteria.