-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Add chroma key support; make passthrough settings real time #2662
base: master
Are you sure you want to change the base?
Conversation
So, looking at the settings I've already got a few critiques:
Edit: Just realized the feathering is basically just my distance thing, but the distances being centered around 1.0 doesn't make a ton of sense, esp considering the visionOS defaults are [0.35, 0.7], so both very low |
alvr/session/src/settings.rs
Outdated
#[schema(strings(display_name = "Hue range"), suffix = "°")] | ||
#[schema(flag = "real-time")] | ||
#[schema(gui(slider(min = 0.0, max = 360.0, step = 1.0)))] | ||
pub hue_range_deg: f32, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh this being in degrees doesn't make a ton of sense? I can see the logic of weighting each of the components in a distance function mayyybe, but the default should be 1.0 weight and should be conveyed as a 0~2 weighting, everything made way more sense when I set this value to 180deg
No description provided.