bugfix(server_core) Fix judder regression caused by streamer-client pose desync #2660
Conversation
shinyquagsire23
changed the title
|
Random footnote I just realized: We're comparing distances between timestamps here, but the client sends predicted target timestamps rather than poll timestamps, so a spike that's 20ms over the average might mess up this function (ie, the timestamps in the queue might look something like [10 20 30 55 50 60]) (It might also accidentally use a poor-quality projected pose rather than a more recent one) |
|
@shinyquagsire23 What you're saying should normally not happen at default statistics history size, but it more probable if it is lowered |
|
bumping bc we should probably get this merged so it at least hits nightlies |
|
bump 2 |
There was a problem hiding this comment.
LGTM from an implementation side, if you already talked the nature of the changes over with @zmerp, then this can get merged
|
I will review as soon as i can, tomorrow the latest. |
Found the actual fix lol, seems to make hands way less sloshy as well?