Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): head prediction scaler #2568

Closed

Conversation

ReinaS-64892
Copy link
Contributor

Please forgive the use of machine translation.

I'm not sure when it started, but it seems that a certain degree of predicted motion is now sent to SteamVR.

I understand the significance and effect of this prediction, but ... in environments with low frame rates (such as when in an instance of VRChat with a large number of players), the prediction is a little too large and noise occurs in the head motion.

Adjusting this to a fixed value may not suit some people, so I tried to make it adjustable in the settings!

It is implemented by adding an argument to predict_motion in alvr\client_core\src\lib.rs and adjusting delta_time_s.

My hope is that it is important to be able to adjust the strength of the prediction, so if there is a better implementation, please let me know!

Original Japanese

機械翻訳を使用することをご容赦ください。

いつからかはわからないですが、ある程度予測されたモーションを SteamVR に送るようになっていますね。
その予測の行う意義や効果はよくわかるのですが ... フレームレートがあまり出ない環境下(VRChat にて非常にプレイヤーの多い インスタンスにいる場合など)では 少し予測が大きく頭のモーションにノイズが発生してしまいます。

これを固定値で調整することは人によって合わないことが発生しうるので、設定にて調整できるようにしてみました!

実装としては、alvr\client_core\src\lib.rs の predict_motion に引数を追加し、 delta_time_s を調整することで実装されています。

私の希望としては、予測の強さを調整できることが大事なので、もっと良い実装があるのであれば教えてほしいです!

@The-personified-devil
Copy link
Collaborator

@zmerp What's your opinion on this? Do you want to defer it to the tracking rewrite or temporarily add it and just adapt that slider to work server-side in the future? Because the concept itself is good.

@zmerp
Copy link
Member

zmerp commented Dec 15, 2024

I'm inclined to not merge this at all. Prediction is not really a opinion matter. Instead i would merge better algorithms to make sure prediction is more accurate

@zmerp
Copy link
Member

zmerp commented Dec 23, 2024

Until we manage to fix head prediction on the Pico 4, I'll make this PR a draft

@zmerp zmerp marked this pull request as draft December 23, 2024 15:53
@zmerp
Copy link
Member

zmerp commented Jan 12, 2025

Pico 4 tracking is fixed in #2612, closing

@zmerp zmerp closed this Jan 12, 2025
@ReinaS-64892 ReinaS-64892 deleted the head-prediction-scaler branch January 13, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants