feat(client): head prediction scaler #2568
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please forgive the use of machine translation.
I'm not sure when it started, but it seems that a certain degree of predicted motion is now sent to SteamVR.
I understand the significance and effect of this prediction, but ... in environments with low frame rates (such as when in an instance of VRChat with a large number of players), the prediction is a little too large and noise occurs in the head motion.
Adjusting this to a fixed value may not suit some people, so I tried to make it adjustable in the settings!
It is implemented by adding an argument to predict_motion in
alvr\client_core\src\lib.rs
and adjusting delta_time_s.My hope is that it is important to be able to adjust the strength of the prediction, so if there is a better implementation, please let me know!
Original Japanese
機械翻訳を使用することをご容赦ください。
いつからかはわからないですが、ある程度予測されたモーションを SteamVR に送るようになっていますね。
その予測の行う意義や効果はよくわかるのですが ... フレームレートがあまり出ない環境下(VRChat にて非常にプレイヤーの多い インスタンスにいる場合など)では 少し予測が大きく頭のモーションにノイズが発生してしまいます。
これを固定値で調整することは人によって合わないことが発生しうるので、設定にて調整できるようにしてみました!
実装としては、
alvr\client_core\src\lib.rs
の predict_motion に引数を追加し、 delta_time_s を調整することで実装されています。私の希望としては、予測の強さを調整できることが大事なので、もっと良い実装があるのであれば教えてほしいです!