Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(xtask): Dont update run submodule update #2556

Merged
merged 2 commits into from
Dec 7, 2024
Merged

chore(xtask): Dont update run submodule update #2556

merged 2 commits into from
Dec 7, 2024

Conversation

The-personified-devil
Copy link
Collaborator

  • Misc small xtask improvements because people keep breaking the build and not looking where in the code the unwrap is

@The-personified-devil
Copy link
Collaborator Author

Oh I forgot this requires the CI fix...

zmerp
zmerp previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-personified-devil
Copy link
Collaborator Author

I'll add --depth=1 to the submodule clone since it's already huge and will only get larger if it does a full clone, so I'll rebase this and add it when the ci pr is merged.

@zmerp
Copy link
Member

zmerp commented Dec 7, 2024

--depth=1 should not be needed because we define the submodule as shallow

@The-personified-devil
Copy link
Collaborator Author

fair enough, I'll still rebase tho

zmerp
zmerp reviewed Dec 7, 2024
View reviewed changes
Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

alvr/session/build.rs Show resolved Hide resolved
@The-personified-devil The-personified-devil merged commit f062e7d into master Dec 7, 2024
8 checks passed
@The-personified-devil The-personified-devil deleted the fix-submod branch December 7, 2024 19:19
The-personified-devil added a commit that referenced this pull request Dec 11, 2024
@The-personified-devil
chore(xtask): Dont run submodule update (#2556)
5adfa80 
* chore(xtask): Dont run submodule update

* fix(linux): Fix compilitation error without jack installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerp zmerp zmerp approved these changes

@Vixea Vixea Awaiting requested review from Vixea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-personified-devil @zmerp