refactor(launcher): refactor client APK installation from launcher #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
requested changes
Nov 26, 2024
zmerp
approved these changes
Nov 27, 2024
The-personified-devil
approved these changes
Nov 29, 2024
zmerp
pushed a commit
that referenced
this pull request
Dec 7, 2024
…2531) * Refactor client APK installation from launcher * Apply requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the launcher use the ADB commands from
alvr_adband should fix the version downgrade error that could occur when installing the client APK. The download location of the local ADB has been changed to be in the release folder.