refactor(client_openxr): ♻️ Do not recreate OpenXR session #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
force-pushed
the
no-session-recreation
branch
from
c73ecf7 to
4986cb3
Compare
|
Also do all the additional sources get unregistered when the client goes back from using them to lobby to another streaming session not using them? |
They don't. Maybe we should do that. technically it's not that hard since we can call |
The-personified-devil
approved these changes
Nov 29, 2024
zmerp
added a commit
that referenced
this pull request
Dec 7, 2024
* refactor(client_openxr): ♻️ Do not recreate OpenXR session * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the need to restart the OpenXR session. This reduces the chances of connection issues. This PR is needed to move towards Vive eye/face tracking support that was previously disabled.
Combined eye gaze support is removed for Quest and Vive. For Pico, we force enable combined eye gaze.
Now the
InteractionContextis always initialized with multimodal tracking enabled, and disabled after connection if it's disabled for server.