Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio): Fix audio watcher busy looping on linux #2372

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(audio): Fix audio watcher busy looping on linux #2372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions alvr/audio/src/linux.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use pipewire::{
},
stream::{StreamFlags, StreamListener, StreamState},
};
use std::{cmp, collections::VecDeque, sync::Arc, thread};
use std::{cmp, collections::VecDeque, sync::Arc, thread, time::Duration};
struct Terminate;

pub fn play_microphone_loop_pipewire(
Expand Down Expand Up @@ -218,7 +218,9 @@ pub fn record_audio_blocking_pipewire(
let is_running_clone_for_pw_terminate: Arc<dyn Fn() -> bool + Send + Sync> =
Arc::clone(&is_running);
thread::spawn(move || {
while is_running_clone_for_pw_terminate() {}
while is_running_clone_for_pw_terminate() {
thread::sleep(Duration::from_millis(500));
}
if pw_sender.send(Terminate).is_err() {
error!(
"Couldn't send pipewire termination signal, deinitializing forcefully.
Expand Down
Loading