Fix controller detection for Pico Neo3 Link #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detect model without connection to server
Fix controller detection for Pico Neo3 Link
Vixea
requested changes
Jun 15, 2024
HoLo85
commented
Jun 15, 2024
Will move the displaying of additional information to a different branch.
|
You'll need to autoformat the changed code to fix the check |
Are those suggestions by rustfmt and are all listed changes marked as error? I think my changes are already formatted for a good readability. |
|
You should format everything according to rustfmt |
|
You need to run |
The-personified-devil
approved these changes
Jun 15, 2024
Meister1593
approved these changes
Jun 15, 2024
Vixea
approved these changes
Jun 15, 2024
zmerp
pushed a commit
that referenced
this pull request
Jul 2, 2024
* fix controller detection for Pico Neo3 Link, show HMD model in app to detect model without connection to server * Revert change in CHANGELOG.md * remove display of HMD model from app Will move the displaying of additional information to a different branch. * reformat code * reformat code
zmerp
pushed a commit
that referenced
this pull request
Jul 2, 2024
* fix controller detection for Pico Neo3 Link, show HMD model in app to detect model without connection to server * Revert change in CHANGELOG.md * remove display of HMD model from app Will move the displaying of additional information to a different branch. * reformat code * reformat code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the detection of the controllers for the Pico Neo3 Link headset. With the introduction of the Pico 4 the HMD was detected as this model which broke the detection of the controller.