-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux hybrid gpu checks #2110
Merged
zmerp
merged 10 commits into
alvr-org:master
from
Meister1593:linux-steamvr-launcher-refactors
May 10, 2024
Merged
Linux hybrid gpu checks #2110
zmerp
merged 10 commits into
alvr-org:master
from
Meister1593:linux-steamvr-launcher-refactors
May 10, 2024
+439
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out platform-specific calls to separate modules
zmerp
requested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure you noticed it, but you don't need to declare modules that wrap completely the content of a source file
zmerp
requested changes
May 6, 2024
zmerp
approved these changes
May 8, 2024
zmerp
pushed a commit
that referenced
this pull request
May 23, 2024
* Add hybrid gpu checks with notice; Refactor steamvr_launcher to move out platform-specific calls to separate modules * Add endline back * Fix clippy; Reformat * Fix typo * Re-add CommandExt for windows * Removed module declarations for platform specific modules * Remove unnecessary empty line in linux_steamvr.rs * Reformat * Move linux steamvr uses into top level in module * Fix compile error from import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for multi-gpu systems with warns on how-to use them in logs when starting up (user should be able to notice that)
Made nvidia check output error of why it could not be initialized
Refactored whole steamvr_launcher code and moved out platform specific code to own modules