Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux hybrid gpu checks #2110

Merged
merged 10 commits into from
May 10, 2024

Conversation

Meister1593
Copy link
Collaborator

@Meister1593 Meister1593 commented May 6, 2024

Added checks for multi-gpu systems with warns on how-to use them in logs when starting up (user should be able to notice that)
Made nvidia check output error of why it could not be initialized
Refactored whole steamvr_launcher code and moved out platform specific code to own modules

@Meister1593 Meister1593 requested a review from zmerp May 6, 2024 20:48
@Meister1593 Meister1593 self-assigned this May 6, 2024
Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure you noticed it, but you don't need to declare modules that wrap completely the content of a source file

@Meister1593 Meister1593 requested a review from zmerp May 7, 2024 18:02
@zmerp zmerp merged commit 130faeb into alvr-org:master May 10, 2024
5 of 6 checks passed
zmerp pushed a commit that referenced this pull request May 23, 2024
* Add hybrid gpu checks with notice; Refactor steamvr_launcher to move out platform-specific calls to separate modules

* Add endline back

* Fix clippy; Reformat

* Fix typo

* Re-add CommandExt for windows

* Removed module declarations for platform specific modules

* Remove unnecessary empty line in linux_steamvr.rs

* Reformat

* Move linux steamvr uses into top level in module

* Fix compile error from import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants