-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDR support #2030
Merged
Merged
Add HDR support #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style-wise, looks ok to to me.
shinyquagsire23
force-pushed
the
feat-hdr
branch
from
March 20, 2024 03:58
9b324ef
to
4c9c0cd
Compare
zmerp
force-pushed
the
master
branch
2 times, most recently
from
March 22, 2024 09:18
d01478e
to
005c4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HDR support by changing compositing framebuffer formats to
DXGI_FORMAT_R16G16B16A16_FLOAT
(conditionally). Currently, it only works with Windows NVENC.Tested and working on:
Other notes:
DXGI_FORMAT_P010
andDXGI_FORMAT_NV12
in an extra shader pass, because NVENC is really picky about texture inputs forNV_ENC_BUFFER_FORMAT_YUV420_10BIT
andNV_ENC_BUFFER_FORMAT_NV12
and the other 10-bit ones didn't really work.clamp()
to remove extended range color (ie, so HDR/float16 games will reduce banding but not require extra tonemapping, which we don't do, to look correct)Bugs:
Shaders were compiled with: